Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dedup and a more expressive ChangeObject #26

Merged
merged 22 commits into from
May 1, 2017

Conversation

LFDM
Copy link
Collaborator

@LFDM LFDM commented Apr 30, 2017

  • Calls dedup at the beginning and at the end of the plugin chain for a maximum effect
  • Moves the onChange hook out of the EntityStore, which doesn't have this odd side effect anymore. Operations trigger the notification now, which also allows us to provide more information (e.g. about the function which has triggered the change!)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 99.38% when pulling 87f2c1d on feat/dedup-and-change-hook into 1f579db on master.

@LFDM LFDM force-pushed the feat/dedup-and-change-hook branch from 87f2c1d to e95859c Compare April 30, 2017 08:29
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 99.38% when pulling e95859c on feat/dedup-and-change-hook into 1f579db on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 99.38% when pulling e95859c on feat/dedup-and-change-hook into 1f579db on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.08% when pulling 27a2aab on feat/dedup-and-change-hook into 1f579db on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 99.387% when pulling bed673d on feat/dedup-and-change-hook into 1f579db on master.

@LFDM
Copy link
Collaborator Author

LFDM commented Apr 30, 2017

I am a little confused as to why coveralls thinks that we're not testing all branches in validator. Looks perfectly fine to me :/ Do you have an idea, @petercrona?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 99.54% when pulling aa7d9e3 on feat/dedup-and-change-hook into 1f579db on master.

@LFDM
Copy link
Collaborator Author

LFDM commented May 1, 2017

Ok, the coverage report thinks that we're missing else branches here, which we aren't. Could try to rewrite this code a bit (which could be done nicer anyway), but maybe not know. Badge is rounded up anyway and shows 100% again ;)

@LFDM LFDM merged commit 2fa0ec5 into master May 1, 2017
@LFDM LFDM deleted the feat/dedup-and-change-hook branch May 1, 2017 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants